Conversation
|
I tested the functionality of this and it looks good. The pop up window shows accurate connections and the buttons redirect to the appropriate component. I would suggest using different Icons for the context menu options so that the arrows are pointing up and down, to correspond with "Upstream" and "Downstream". Maybe slanted up/down arrows? Just a thought. |
Thanks @Freedom9339. I updated the arrows, as suggested. The upstream context menu item shows an arrow pointing up and to the left, and downstream shows down and to the right. It's slightly more intuitive and looks good. |
0d9d316 to
c56d29a
Compare
|
Will review... |
rfellows
left a comment
There was a problem hiding this comment.
Thanks for restoring View Connections. The effect/filter path and unauthorized/empty handling look directionally right, but this isn’t merge-ready yet.
Verified locally on this branch (npx nx test nifi --runInBand): 6 failed / 2,825 passed, all in component-connections-dialog.component.spec.ts. Lint and a development build passed.
Must-fix before merge:
- The new dialog tests fail (empty mock store + assertions still targeting
goTo()/ a partial row shape). - Remote-port cells navigate with the port id and
ComponentType.RemoteProcessGroup. - Source/Destination Process Group cells navigate to
/process-groups/{groupId}/ProcessGroup/{groupId}when the endpoint is the group currently on the canvas.
The five-column clickable table is a reasonable UX, but it should follow the existing dialog listing-table pattern (bounded scroll, sticky header, striped rows) used by Local Changes and Change Version, and use <a> for in-cell navigation rather than mat-button.
| <tr mat-header-row *matHeaderRowDef="displayedColumns"></tr> | ||
| <tr mat-row *matRowDef="let row; columns: displayedColumns"></tr> |
There was a problem hiding this comment.
Add the sticky header and striped rows used by other listing tables.
| <tr mat-header-row *matHeaderRowDef="displayedColumns"></tr> | |
| <tr mat-row *matRowDef="let row; columns: displayedColumns"></tr> | |
| <tr mat-header-row *matHeaderRowDef="displayedColumns; sticky: true"></tr> | |
| <tr mat-row *matRowDef="let row; let even = even; columns: displayedColumns" [class.even]="even"></tr> |
There was a problem hiding this comment.
Sticky header was added. I attempted to add the striped rows with the even setting. I do not see it rendered though. I'll keep looking at it, but I'd appreciate insights you may have.
…am connections. View connections > upstream/downstream is available in the context menu from a variety of components: input/output ports, processors, process groups, remote process groups and funnels.
…in the parent group to support port-to-port connection in sibling PGs Update table formatting with fixed header and scrollable
…to match current state of upstream/downstream dialog functionality; original was from a older implementation
…ature of remote port components
f2021e7 to
5399070
Compare
@rfellows Thanks for taking the time to review and catch a few things that needed attention. I'm made numerous updates.
|
…am connections. View connections > upstream/downstream is available in the context menu from a variety of components: input/output ports, processors, process groups, remote process groups and funnels.
Summary
In NiFi 1.x, there was a context menu option for View Connections > upstream/downstream. This is available from any component, but it is particularly useful for input/output ports. The reason is that the connections to ports are not visible on the graph at the same level as the ports themselves. The user must go to the parent process group, and then there is ambiguity which connections are connected to which ports in cases where there are multiple connections and ports on the process group.
A key feature of the View Connections table is that each item in the table is clickable and will navigate to the selected component or connection.
Restoring this feature makes it far easier to navigate the graph and identify complex routing/connectivity issues in the flow.
NIFI-14777
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Verification was performed by interacting with the graph and testing a variety of scenarios including:
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation